- 
                Notifications
    You must be signed in to change notification settings 
- Fork 109
Callback to inform about loadSubset deduplication #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: samwillis/predicate-utils
Are you sure you want to change the base?
Conversation
| 🦋 Changeset detectedLatest commit: 313299a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| More templates
 @tanstack/angular-db
 @tanstack/db
 @tanstack/db-ivm
 @tanstack/electric-db-collection
 @tanstack/query-db-collection
 @tanstack/react-db
 @tanstack/rxdb-db-collection
 @tanstack/solid-db
 @tanstack/svelte-db
 @tanstack/trailbase-db-collection
 @tanstack/vue-db
 commit:  | 
| Size Change: +49 B (+0.05%) Total Size: 89.4 kB 
 ℹ️ View Unchanged
 | 
| Size Change: 0 B Total Size: 2.89 kB ℹ️ View Unchanged
 | 
7c18807    to
    a732165      
    Compare
  
    a844ab2    to
    61beafa      
    Compare
  
    |  | ||
| constructor( | ||
| loadSubset: (options: LoadSubsetOptions) => true | Promise<void> | ||
| loadSubset: (options: LoadSubsetOptions) => true | Promise<void>, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

a732165    to
    6ee696c      
    Compare
  
    61beafa    to
    313299a      
    Compare
  
    
Adds an
onDeduplicatecallback to theDeduplicatedLoadSubsetclass from #668. Some collections (like the query collection) need this callback such that they are informed if a query is deduplicated. This is important because e.g. the query collection needs to manually reference count rows such that it can GC rows when they are not referenced by any query anymore. But this means they need to be able to track rows also for deduplicated queries.