Skip to content

test(react-query/useSuspenseQuery): switch to fake timers and replace 'waitFor' with 'vi.waitFor' #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2025
Merged

test(react-query/useSuspenseQuery): switch to fake timers and replace 'waitFor' with 'vi.waitFor' #9357

merged 2 commits into from
Jul 5, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jul 4, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4eb924a

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 30s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 28s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-05 15:49:25 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 4, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9357

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9357

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9357

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9357

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9357

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9357

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9357

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9357

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9357

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9357

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9357

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9357

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9357

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9357

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9357

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9357

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9357

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9357

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9357

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9357

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9357

commit: 4eb924a

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (026c050) to head (4eb924a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9357       +/-   ##
===========================================
+ Coverage   45.37%   84.29%   +38.91%     
===========================================
  Files         207       25      -182     
  Lines        8277      363     -7914     
  Branches     1865      108     -1757     
===========================================
- Hits         3756      306     -3450     
+ Misses       4080       48     -4032     
+ Partials      441        9      -432
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.93% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

manudeli
manudeli approved these changes Jul 5, 2025
View reviewed changes
Copy link
Collaborator

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace vi.waitFor with vi.advanceTimersByTimeAsync after this pull request merged

@manudeli manudeli merged commit ed66939 into TanStack:main Jul 5, 2025
7 checks passed
@sukvvon sukvvon deleted the test/react-query-useSuspenseQuery-fake-timers-vi-waitFor branch July 5, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukvvon @manudeli