test: add e2e test for ssr error handling #4339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELEASE_ALL
RELEASE_ALL
Currently, none of the packages (i.e `packages/*`) need `vite`
bundled as a `dependency`. So its been moved to the
`devDependencies` and had the version opened using
`"peerDependencies": { "vite": ">=6.0.0" }`.
Additionally, `vite` has been added as a `dependency` to
the Start end-to-end sandboxes.
In a later PR, `vite` will need to be added to all the
TanStack Start examples (i.e. `examples/**/start-*`).
…anStack#4137) Only import `routeCode` if `node.fullPath` is available.
…t + matching server function handler route on Windows (TanStack#4146)
Co-authored-by: chorobin <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> fixes TanStack#4285 fixes TanStack#4195 fixes TanStack#4182
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
|
View your CI Pipeline Execution ↗ for commit 2a8051a.
☁️ Nx Cloud last updated this comment at |
|
so these tests fail until changes in the router are made? |
|
I guess according to the closed PR it is fixed in the alpha branch? |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
|
@meouwu-dev thanks for these tests, it could help to avoid future regressions. Could you maybe rebase this on the latest main? Also instead of accessing the "links" through href could you please update to access these by way of test-id? something like "await page.getByTestId("error-handling-via-beforeLoad").click()" |
schiller-manuel
force-pushed
the
alpha
branch
3 times, most recently
from
9e45354 to
3cd7e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e test for #3462