WIP: feat: full document hydration for solid #4341

brenelz · 2025-06-07T22:36:55Z

Basically we want to allow a user to have full access to the html document. Alexis mentioned to me that the html tag can't be hydrated on the client so had to take a bit of a different approach of customizing the server entry.

RELEASE_ALL

Currently, none of the packages (i.e `packages/*`) need `vite` bundled as a `dependency`. So its been moved to the `devDependencies` and had the version opened using `"peerDependencies": { "vite": ">=6.0.0" }`. Additionally, `vite` has been added as a `dependency` to the Start end-to-end sandboxes. In a later PR, `vite` will need to be added to all the TanStack Start examples (i.e. `examples/**/start-*`).

…TanStack#4136)

…anStack#4137) Only import `routeCode` if `node.fullPath` is available.

…t + matching server function handler route on Windows (TanStack#4146)

…anStack#4147)

)

…anStack#4149)

…ack#4154)

…4291) fixes TanStack#4289

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> fixes TanStack#4285 fixes TanStack#4195 fixes TanStack#4182

fixes TanStack#4275

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

nx-cloud · 2025-06-07T22:37:23Z

View your CI Pipeline Execution ↗ for commit 77f6ff8.

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	6m 38s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	20s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-08 05:01:55 UTC

pkg-pr-new · 2025-06-07T22:39:11Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4341

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4341

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4341

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4341

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4341

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4341

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4341

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4341

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4341

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4341

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4341

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4341

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4341

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4341

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4341

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4341

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4341

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4341

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4341

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4341

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4341

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4341

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4341

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4341

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4341

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4341

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4341

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4341

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4341

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4341

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4341

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4341

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4341

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4341

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4341

commit: 77f6ff8

examples/solid/start-bare/src/routes/__root.tsx

brenelz · 2025-06-08T04:57:22Z

packages/start-server-core/src/createStartHandler.ts

 }: {
  createRouter: () => TRouter
+  RootDocument?: any


i wasn't sure how to type this since its a Solid component but its in the core package

brenelz · 2025-06-08T04:57:30Z

packages/start-server-core/src/handlerCallback.ts

@@ -5,6 +5,7 @@ export interface HandlerCallback<TRouter extends AnyRouter> {
    request: Request
    router: TRouter
    responseHeaders: Headers
+    RootDocument?: any


examples/solid/start-bare/src/routes/__root.tsx

brenelz · 2025-08-08T21:51:04Z

This is so out of date i will just close

tannerlinsley and others added 30 commits May 10, 2025 14:54

Devinxi (TanStack#4111)

855b03f

fix: RELEASE_ALL

6e5b7a3

RELEASE_ALL

release: v1.20.3-alpha.1

1ceda30

fix: RELEASE_ALL

0b7aefd

RELEASE_ALL

release: v1.120.4-alpha.1

bc2dfa1

fix: clean up Vite versions (TanStack#4130)

e3fd36b

docs(start): Fix contents outdated by Devinxi (TanStack#4125)

82d14bd

release: v1.120.4-alpha.2

c997f90

release: v1.120.4-alpha.3

99a944b

fix(router-generator): exit conditions when using verboseFileRoutes (…

35f6520

…TanStack#4136)

release: v1.120.4-alpha.4

ef337e7

fix(start-plugin-core): patches for Virtual Routes in Server Routes (T…

94400a2

…anStack#4137) Only import `routeCode` if `node.fullPath` is available.

release: v1.120.4-alpha.5

016e5f0

fix(start-plugin-core): include "vite/client" types (TanStack#4139)

20937af

release: v1.120.4-alpha.6

a57676e

fix(start-server-core): appending headers to immutable response objec…

d5c2e6d

…t + matching server function handler route on Windows (TanStack#4146)

ci: apply automated fixes

bef4dab

chore: lint

565c8a0

release: v1.120.4-alpha.7

6542287

refactor(start-server-core): use utility functions from router-core (T…

94c1284

…anStack#4147)

release: v1.120.4-alpha.8

4533d30

docs(start): remove validators from "server routes" guide (TanStack#4148

62a044e

)

fix(start-plugin-core): remove backslashes from declaration import (T…

ac7db71

…anStack#4149)

release: v1.120.4-alpha.9

32f1a8b

feat(router-core): type level parsing of path params (TanStack#4144)

9f63d40

release: v1.120.4-alpha.10

8d4a7e8

docs(start): Server Functions can be called from Server Routes (TanSt…

6bde41f

…ack#4154)

docs(start): server-routes (TanStack#4155)

e6fab6a

docs: update build from scratch

418fac9

schiller-manuel and others added 11 commits May 30, 2025 23:48

chore: merge main (TanStack#4283)

6a97386

fix: make route HMR handling robust against route deletion (TanStack#…

7c2bc2f

…4291) fixes TanStack#4289

release: v1.121.0-alpha.22

f290ac9

fix: exclude virtual modules from optimizeDeps (TanStack#4295)

3f700bf

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> fixes TanStack#4285 fixes TanStack#4195 fixes TanStack#4182

release: v1.121.0-alpha.23

dec25aa

docs(start): remove example of Server Routes client callers

17a3b42

fixes TanStack#4275

fix: don't add all @TanStack packages to noExternal (TanStack#4312)

5ea0dc7

release: v1.121.0-alpha.24

273fa8b

fix: Preload assets on windows (TanStack#4324)

3827b03

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

release: v1.121.0-alpha.25

a122639

feat: full document hydration for solid

bbaaa78

brenelz changed the title ~~feat: full document hydration for solid~~ WIP: feat: full document hydration for solid Jun 7, 2025

github-actions bot added package: solid-start-client package: solid-start-plugin package: solid-start-server labels Jun 7, 2025

brenelz marked this pull request as draft June 7, 2025 22:37

lxsmnsyc reviewed Jun 8, 2025

View reviewed changes

examples/solid/start-bare/src/routes/__root.tsx Outdated Show resolved Hide resolved

brenelz added 2 commits June 7, 2025 23:04

chore: use app div for hydration

3d7e590

feat: update to allow customizable root document

77f6ff8

github-actions bot added the package: start-server-core label Jun 8, 2025

brenelz commented Jun 8, 2025

View reviewed changes

lxsmnsyc reviewed Jun 8, 2025

View reviewed changes

examples/solid/start-bare/src/routes/__root.tsx Show resolved Hide resolved

schiller-manuel force-pushed the alpha branch 2 times, most recently from de916e0 to a8e467c Compare August 8, 2025 20:55

brenelz changed the base branch from alpha to main August 8, 2025 21:25

brenelz closed this Aug 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

WIP: feat: full document hydration for solid #4341

WIP: feat: full document hydration for solid #4341

Uh oh!

brenelz commented Jun 7, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Jun 7, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

brenelz Jun 8, 2025

Uh oh!

brenelz Jun 8, 2025

Uh oh!

Uh oh!

brenelz commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

WIP: feat: full document hydration for solid #4341

WIP: feat: full document hydration for solid #4341

Uh oh!

Conversation

brenelz commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

brenelz Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

brenelz Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brenelz commented Aug 8, 2025

Uh oh!

Uh oh!

brenelz commented Jun 7, 2025 •

edited

Loading

nx-cloud bot commented Jun 7, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 7, 2025 •

edited

Loading