Remove finalization checkpoint #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstdl
reviewed
Jul 24, 2024
Comment on lines
+58
to
+75
| switch slot := subscriptionData["slot"].(type) { | ||
| case float64: | ||
| // JSON numbers are decoded into float64 by default | ||
| r.onFinalizedEpoch <- common.GetEpochFromSlot(int64(slot)) | ||
| case int: | ||
| // Handle int if by any chance it's parsed as such | ||
| r.onFinalizedEpoch <- common.GetEpochFromSlot(int64(slot)) | ||
| case string: | ||
| // If "epoch" is provided as a string, parse it to an integer | ||
| if slotVal, err := strconv.ParseUint(slot, 10, 64); err == nil { | ||
| r.onFinalizedEpoch <- common.GetEpochFromSlot(int64(slotVal)) | ||
| r.log.WithField("slot", slotVal).Debug("Slot value") | ||
| } else { | ||
| r.log.WithError(err).Error("Error converting epoch from string to uint64") | ||
| } | ||
| default: | ||
| r.log.WithField("data", subscriptionData).Warn("Epoch value is of an unrecognized type") | ||
| } |
Collaborator
There was a problem hiding this comment.
move this convertion to a separate method and leave something like r.onFinalizedEpoch <- common.ToInt64(slot) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.