feat - 배너 정보 불러오기 #197
Merged
feat - 배너 정보 불러오기 #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseysh
approved these changes
Nov 19, 2024
Member
kseysh
left a comment
kseysh
left a comment
There was a problem hiding this comment.
깔끔하게 잘 작성해주신 것 같아요 👍
코멘트 하나만 남겼는데 확인 부탁드립니다!
Comment on lines
1
to
9
| package sopt.org.hmh.domain.banner.repository; | ||
|
|
||
| import sopt.org.hmh.domain.banner.Banner; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| public interface BannerRepository { | ||
| Optional<Banner> findTopByOrderByIdAsc(); | ||
| } |
Member
There was a problem hiding this comment.
P4. Banner 엔티티는 Jpa외에 복잡한 쿼리를 사용할 일이 없을 것 같아 JpaRepository 하나만 있는게 코드 복잡도 측면에서 더 좋을 것 같은데 어떠신가요?
저는 보통 복잡한 쿼리가 필요하여 Querydsl 사용시에 이렇게 나누는 편이라 복잡한 쿼리가 필요없다면 하나만 유지해도 좋을 것 같아요!
Collaborator
Author
There was a problem hiding this comment.
좋은 생각입니당! 빠른 코리 감사드려요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항