Fix standalone library compilation #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerator's ability to filter away editor-only types from the scanned list.
…voked even though the object is null which led to a NullReferenceException.
…h IL2CPP for iOS or Android, this issue would cause deserialization errors saying. `Error: Reached end of array after X elements, when Y elements were expected.` when using the binary data format. On the surface, the error was due to bad serialization of 8-byte (long/ulong) values resulting in random values occupying the higher four bytes of the value in the serialized data. The ultimate cause after a long period of investigation ended up being an apparent newly introduced compiler error in IL2CPP when translating assemblies to C++, related to inlining of methods that use unsafe code; adding a flag to disable inlining for all binary writer methods that write values larger than 4 bytes resolves the issue.
…not allowed to be called during serialization" and possibly other similar exceptions would be logged during an AOT support scan. Processing and filtering of all registered types for AOT support is now delayed to the end of the scan where the Unity API is legal to use, rather than performed immediately as they are registered.
…ssue would cause some data serialized on iOS using xcode 15 and above to become corrupt; specifically, this issue affected binary serialization of 64 and 128 bit primitive values (long, ulong, double, guid, decimal). In the end, the method of how the data is written to the data buffer was changed entirely in a way that didn't trigger the new xcode compiler bug that caused faulty inlining that would corrupt the memory of stack variables.
Replacing InvariantCulture string equality checks (and a few calls to StartsWith) with Ordinal comparer.
…n addressables due to the PlayerDataGroupSchema type having been removed from the Unity.Addressables module.
…enerator's ability to filter away editor-only types from the scanned list. (cherry picked from commit 305dedd)
…brary # Conflicts: # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedBehaviour.cs # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedComponent.cs # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedMonoBehaviour.cs # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedScriptableObject.cs # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedStateMachineBehaviour.cs # OdinSerializer/Unity Integration/SerializedUnityObjects/SerializedUnityObject.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core standalone library compilation was failing due to missing conditional compilation directives.
Also merged
masterbranch.