Fix LPM: Return and use array instead of just 1st string #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuhaas22
requested review from
cshilwant,
glneo,
khasim-syed and
sskartheekadivi
as code owners
A config in toml can have multiple values, separated by space. The
`read_config` function reads all of these space-separated values as
individual strings in a `value` array. But then it returns only the
first string by doing `echo ${value}`. Thus even if a config had
multiple values, only the 1st gets returned.
This is usually not a problem since almost all of the configs so far
have single-values. But in case of optee's make arguments, which are
multiple, it returns only the 1st, and not the 2nd. Due to this, LPM
doesn't work on am62pxx-evm, since the 2nd make argument is also
necessary for making it work.
So return the entire array from `read_config`. And pass the entire array
to optee's `make` command. Also fix the value of the `platform` config
for am62pxx-evm.
This commit fixes LPM.
Signed-off-by: Suhaas Joshi <[email protected]>
jsuhaas22
force-pushed
the
am62p-fix-lpm
branch
from
2fd026f to
ea1a444
Compare
cshilwant
approved these changes
Nov 22, 2024
Member
cshilwant
left a comment
cshilwant
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A config in toml can have multiple values, separated by space. The
read_configfunction reads all of these space-separated values as individual strings in avaluearray. But then it returns only the first string by doingecho ${value}. Thus even if a config had multiple values, only the 1st gets returned.This is usually not a problem since almost all of the configs so far have single-values. But in case of optee's make arguments, which are multiple, it returns only the 1st, and not the 2nd. Due to this, LPM doesn't work on am62pxx-evm, since the 2nd make argument is also necessary for making it work.
So return the entire array from
read_config. And pass the entire array to optee'smakecommand. This commit fixes LPM.