Skip to content

ci: bump actions/setup-python to v5 #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TomJGooding
Copy link
Contributor

I noticed looking at recent workflow runs that there's a number of warnings where the cache has failed to save/restore.

Apparently old versions of the actions cache service are now deprecated (actions/setup-python#1007).

Bumping actions/setup-python to v5 should hopefully fix the caching and help speed up CI runs!

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

I noticed looking at recent workflow runs that there's a number of
warnings where the cache has failed to save/restore.

Apparently old versions of the actions cache service are now deprecated
(actions/setup-python#1007).

Bumping actions/setup-python to v5 should hopefully fix the caching and
help speed up CI runs!
@TomJGooding
Copy link
Contributor Author

Annoyingly the flaky test isn't fixed after all, but I don't see any workflow warnings about the cache!

@TomJGooding
Copy link
Contributor Author

The latest workflow run confirms the cache is now restored successfully.

Does this caching actually help speed up CI runs? Based on some quick comparisons, possibly not thanks to Windows!

Workflow Step ubuntu-latest, 3.12 macos-latest, 3.12 windows-latest, 3.12 Total
Before caching
Set up Python 2s 2s 7s
Install dependencies 9s 9s 34s
Total 11s 11s 41s 63s
After caching
Set up Python 5s 5s 49s
Install dependencies 1s 1s 2s
Total 6s 6s 51s 63s

@TomJGooding
Copy link
Contributor Author

TomJGooding commented Aug 8, 2025

Marked as ready to review. The caching could simply be removed if there's actually no benefit, but it's difficult to compare workflow runtimes.

@TomJGooding TomJGooding marked this pull request as ready for review August 8, 2025 21:55
@willmcgugan willmcgugan merged commit 1105dd1 into Textualize:main Aug 12, 2025
54 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants