fix: add set_options to SelectionList #6224
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threw me off when this happened to rovr, because the self._selected never got cleared when `set_options` was used instead of `clear_options` + `add_options`
NSPC911
added a commit
to NSPC911/rovr
that referenced
this pull request
Nov 11, 2025
waiting for a new release that has Textualize/textual#6224 merged
TomJGooding
reviewed
Nov 11, 2025
Collaborator
TomJGooding
left a comment
TomJGooding
left a comment
There was a problem hiding this comment.
Are you sure this is correct? You can build a SelectionList with tuples or Selection objects, but here it looks like you're trying to use SelectionType?
Contributor
Author
not really sure which one to use, given that |
Collaborator
|
I'm confused, Did you check your code actually worked, or just throw the PR over the wall? |
Contributor
Author
|
The general code worked, but I'm not sure about which class to use as the type hint for the function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threw me off when this happened to rovr, because the self._selected never got cleared when
set_optionswas used instead ofclear_options+add_optionsPlease review the following checklist.