Skip to content

Conversation

GoulielmosFloros
Copy link
Contributor

Description

modified package.json files to include lit as peer and devdependencies.

modified vite.config.js to prevent Lit from being included in my final build.

Reviewed-by: Goulielmos Floros
Ref: #25

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

modified package.json files to include lit as peer and devdependencies.

modified vite.config.js to prevent Lit from being included in my final build.

Reviewed-by: Goulielmos Floros
Ref: ThatOpen#25
@HoyosJuan
Copy link
Member

Hey @GoulielmosFloros! Thanks for this PR.

If you have set Lit as a peer dependency, then you:

  1. Can remove it from the dependencies.
  2. Don't have to modify the vite file as peer dependencies are never included in the final build.

May you update those things, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants