Implement locks #13

pupnewfster · 2019-09-04T20:14:31Z

No description provided.

src/api/java/com/teamacronymcoders/epos/api/EposAPI.java

src/api/java/com/teamacronymcoders/epos/api/locks/LockRegistry.java

src/main/java/com/teamacronymcoders/epos/Epos.java

src/main/java/com/teamacronymcoders/epos/locks/DefaultLocks.java

src/main/java/com/teamacronymcoders/epos/locks/FuzzyLockKeyTypes.java

pupnewfster · 2019-09-06T22:36:12Z

src/main/java/com/teamacronymcoders/epos/locks/keys/tag/ParentTagLockKey.java

+        } else if (object instanceof FluidState) {
+            return fromTags(((FluidState) object).getFluid().getTags());
+        }
+        return null;


Add support for EntityType tags (the final type of built in tag in MC that this doesn't already support)

If you're gonna do things regarding tags, you should add a way for an addon to register a Function<T,Tags>

By this do you mean that they would be registering a function such as Function<Item, Tag<Item>> or what do you have in mind by this.

For now I left a TODO to go back at some point and look into letting mods register other types of Tags as the system probably needs some work once we come up with more potential use cases.

src/api/java/com/teamacronymcoders/epos/api/locks/LockRegistry.java

src/main/java/com/teamacronymcoders/epos/locks/DefaultLocks.java

src/api/java/com/teamacronymcoders/epos/api/EposAPI.java

src/main/java/com/teamacronymcoders/epos/locks/keys/HungerLockKey.java

src/main/java/com/teamacronymcoders/epos/locks/keys/ItemLockKey.java

src/main/java/com/teamacronymcoders/epos/locks/keys/SaturationLockKey.java

src/main/java/com/teamacronymcoders/epos/locks/keys/harvest/HarvestLockKey.java

SkySom · 2019-09-07T00:04:32Z

src/main/java/com/teamacronymcoders/epos/locks/keys/tag/ParentTagLockKey.java

+        } else if (object instanceof FluidState) {
+            return fromTags(((FluidState) object).getFluid().getTags());
+        }
+        return null;


If you're gonna do things regarding tags, you should add a way for an addon to register a Function<T,Tags>

src/main/java/com/teamacronymcoders/epos/locks/keys/harvest/ToolHarvestLockKey.java

pupnewfster · 2019-09-07T21:29:46Z

src/main/java/com/teamacronymcoders/epos/locks/keys/tag/ParentTagLockKey.java

+        } else if (object instanceof FluidState) {
+            return fromTags(((FluidState) object).getFluid().getTags());
+        }
+        return null;


By this do you mean that they would be registering a function such as Function<Item, Tag<Item>> or what do you have in mind by this.

…properties

…re code for arrays

… all

…r system

…quirements

…can access it easier from another machine if I don't work on it more before then.

…has changed yet beyond fixing the compiler errors, a couple typos, moving the lock registry implementation details to not be part of the API and adjusting a couple things that check Items to check IItemProviders instead

pupnewfster requested review from Lanse505 and SkySom September 4, 2019 20:14

Lanse505 reviewed Sep 4, 2019

View reviewed changes

pupnewfster commented Sep 6, 2019

View reviewed changes

SkySom requested changes Sep 7, 2019

View reviewed changes

pupnewfster commented Sep 7, 2019

View reviewed changes

pupnewfster added 9 commits October 3, 2019 12:22

Update dependencies, and move titanium version declaration to gradle.…

64438f0

…properties

Initial port/rebase of #1 with a few minor improvements/namings

fd7170b

Cleanup a bunch of TODOs and sketch out ideas for some more tests

f675c2b

Implement tests for NBT comparison, and deduplicate some of the compa…

08d41ff

…re code for arrays

Implement remaining tests

5b75ed7

Make a lot of the requested changes. Some more still need to be made.

3bcfde8

Prep work on creating a BlockStateLockKey, currently does not work at…

2fdeeb3

… all

Run optimize imports to remove all the unused imports

c3713a5

Implement BlockStateLockKey

d1f97f6

pupnewfster force-pushed the feature_locks branch from 7097401 to d1f97f6 Compare October 3, 2019 16:59

pupnewfster added 5 commits October 3, 2019 14:07

Create a multi lock key creator system

d312d0b

Remove ParentLockKey as it can be done via the new MultiLockKeyCreato…

18e964c

…r system

First pass outlining some of the things that will be needed for/by re…

2e0af32

…quirements

Commit various parts of my work on requirement comparision so that I …

9f27d64

…can access it easier from another machine if I don't work on it more before then.

More docs and various other stuff I don't remember what it is

266f6b4

Implement locks #13

Are you sure you want to change the base?

Implement locks #13

Uh oh!

Conversation

pupnewfster commented Sep 4, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pupnewfster Sep 6, 2019

Choose a reason for hiding this comment

Uh oh!

SkySom Sep 7, 2019

Choose a reason for hiding this comment

Uh oh!

pupnewfster Sep 7, 2019

Choose a reason for hiding this comment

Uh oh!

pupnewfster Oct 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SkySom Sep 7, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pupnewfster Sep 7, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants