Bit_Trie Implementation for Max Xor Computation in an Array #3022
+220
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataWorshipper
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
requested changes
Oct 2, 2025
| * each number in the array. | ||
| * | ||
| * Worst Case Time Complexity: O(n * log(MAX_VAL)) where MAX_VAL is the maximum | ||
| * value in the array (64-bit integers here) Space Complexity: O(n * |
There was a problem hiding this comment.
Line break for the space complexity
| * @param nums vector of unsigned 64-bit integers | ||
| * @return maximum XOR of any pair | ||
| */ | ||
| std::uint64_t findMaximumXOR(const std::vector<std::uint64_t>& nums) { |
There was a problem hiding this comment.
Follow snake case.
| */ | ||
| static void test() { | ||
| using bit_manipulation::max_xor_bit_trie::findMaximumXOR; | ||
|
|
There was a problem hiding this comment.
Add empty vector test.
|
Hello i have commited the changes that you requested for also followed snake case conventions,could you please review the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request adds a C++ implementation of the Bitwise Trie (Binary Trie) to solve the Maximum XOR of Two Numbers in an Array problem from LeetCode: Maximum XOR Problem.
The algorithm constructs a binary trie for all 64-bit integers in the array and efficiently queries the maximum XOR achievable for each number. The implementation is self-contained, includes comprehensive Doxygen-style documentation, and comes with multiple test cases to ensure correctness.
Checklist
max_xor_bit_trie.cpp)Notes: Implements an efficient O(n * log(MAX_VAL)) solution for finding the maximum XOR pair in an array using a bitwise trie. Includes extensive tests for edge cases, duplicates, and large arrays.