Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Addresses review comments from the 4.11 release prep PR.

Changes

  • FullscreenGrab zoom handling: Skip transform creation when zooming out at base scale (no-op case)
  • GlobalLang exception logging: Add debug output for failed language initialization instead of silent catch
  • FullscreenGrab GC removal: Remove forced GC.Collect() calls — let runtime manage memory naturally
  • HistoryService resource leak: Dispose CachedBitmap before reassignment to prevent GDI object leak
  • Floating point comparison: Use epsilon comparison instead of direct equality check for pan values
  • FindAndReplaceWindow style: Refactor two if/else blocks to ternary operators
// Before
if (panX != 0 || panY != 0)

// After
const double Epsilon = 1e-6;
if (Math.Abs(panX) > Epsilon || Math.Abs(panY) > Epsilon)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…removal, resource disposal, epsilon comparison, ternary operators

Co-authored-by: TheJoeFin <[email protected]>
Copilot AI changed the title [WIP] Prepare for release of version 4.11 Apply code review feedback from PR #581 Nov 28, 2025
Copilot AI requested a review from TheJoeFin November 28, 2025 20:50
Copilot finished work on behalf of TheJoeFin November 28, 2025 20:50
Modified the `teal` color to include full opacity. Updated `Foreground` properties in `GeneralSettings.xaml` to ensure consistent theming for buttons and hyperlinks. Added commented-out code for potential future accent color handling.
Improved the tooltip for the calc toggle button to clarify text wrapping behavior. Added explanatory `TextBlock` elements to the UI for better user guidance. Updated logic to disable text wrapping when the calc pane is visible and restore the previous state when hidden. Introduced `_previousTextWrapping` to manage text wrapping state persistently.
@TheJoeFin TheJoeFin marked this pull request as ready for review November 29, 2025 16:25
@TheJoeFin TheJoeFin merged commit 965aaec into 4.11-prep-for-release Nov 29, 2025
@TheJoeFin TheJoeFin deleted the copilot/sub-pr-581 branch November 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants