Skip to content

Conversation

@mao-sz
Copy link
Contributor

@mao-sz mao-sz commented Aug 27, 2025

Because

#29780 removed the eslint-config-airbnb material which also removed material that clarified nothing was needed extra between Prettier and ESLint when using the default ESLint rule set. I thought this was fine since there'd be nothing in the lesson indicating something like eslint-config-prettier would be needed, but it's actually mentioned in the Prettier installation guide.

Not a huge issue, since all eslint-config-prettier does is disable some rules which aren't even enabled in the default ESLint rule set (they've been deprecated for ages now), but on occasion, a learner has been confused configuring eslint-config-prettier in the first place. Since it's not needed, probably sensible to just advise it's not needed.

This PR

  • Adds clarifying sentence about not needing eslint-config-prettier

Issue

N/A

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Aug 27, 2025
@ManonLef ManonLef requested review from a team and bycdiaz and removed request for a team August 28, 2025 18:57
Copy link
Member

@rlmoser99 rlmoser99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a note here would be useful since we have seen people get confused about this. Thanks for taking the time to add this clarification. Approving and will let you merge since you are back on our team. 🎉

@mao-sz mao-sz merged commit 5b7a4e4 into TheOdinProject:main Sep 4, 2025
3 checks passed
@mao-sz mao-sz deleted the prettier-eslint branch September 4, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: JavaScript Involves the JavaScript course

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants