JS Linting: Clarify lack of need for eslint-config-prettier with ESLint defaults #30042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
#29780 removed the eslint-config-airbnb material which also removed material that clarified nothing was needed extra between Prettier and ESLint when using the default ESLint rule set. I thought this was fine since there'd be nothing in the lesson indicating something like
eslint-config-prettierwould be needed, but it's actually mentioned in the Prettier installation guide.Not a huge issue, since all
eslint-config-prettierdoes is disable some rules which aren't even enabled in the default ESLint rule set (they've been deprecated for ages now), but on occasion, a learner has been confused configuringeslint-config-prettierin the first place. Since it's not needed, probably sensible to just advise it's not needed.This PR
eslint-config-prettierIssue
N/A
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection