Skip to content

Conversation

@mao-sz
Copy link
Contributor

@mao-sz mao-sz commented Sep 1, 2025

Because

TOP001-008 had test files that omitted trailing periods in LO items, now enforced by TOP009. These ought to be fixed so any future changes to those rules would have their test files flag errors only for the custom rule being tested.

This PR

  • Adds trailing period to TOP001-008 test files' LO items as necessary.
  • Disables TOP008 for an intentional violation in the TOP006 test file to reduce error noise.

Issue

N/A

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Markdownlint Involves anything related to the curriculum repo linter label Sep 1, 2025
Test file should showcase TOP006 only. TOP008 violation is intentional here, just don't flag it due to error noise.
@mao-sz mao-sz force-pushed the custom-lint-test-fix branch from 1f74dc1 to 187d506 Compare September 1, 2025 17:30
Copy link
Member

@ManonLef ManonLef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ManonLef ManonLef merged commit b13c172 into TheOdinProject:main Sep 2, 2025
1 of 2 checks passed
@mao-sz mao-sz deleted the custom-lint-test-fix branch September 2, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: Markdownlint Involves anything related to the curriculum repo linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants