-
Notifications
You must be signed in to change notification settings - Fork 5
도메인 주도 설계란 무엇인가? 1주차 - 권태형 #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TaeHyoungKwon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request contains TaeHyoungKwon's notes and discussion points on the first three chapters of the book 'Domain-Driven Design Quickly'. The notes cover key concepts, personal thoughts, and discussion prompts related to Domain-Driven Design (DDD), Ubiquitous Language, and Model-Driven Design. The author shares their experiences and opinions on applying DDD principles in real-world scenarios, raising questions about the practical challenges and potential pitfalls of DDD implementation.
Highlights
- Domain-Driven Design: The author discusses the importance of domain modeling for communication between different teams and emphasizes that the goal of software development is to solve real-world problems.
- Ubiquitous Language: The author highlights the need for a common language between developers and domain experts to avoid communication errors and ensure that the code accurately reflects the domain.
- Model-Driven Design: The author shares their thoughts on layered architecture, service objects, and aggregates, questioning the overuse of service objects and emphasizing the importance of considering the complexity of the domain when choosing an architecture.
Changelog
Click here to see the changelog
- 2025/Domain-Driven Design Quickly/taehyoung/1.md
- Added notes and discussion points for Chapter 1: What is Domain-Driven Design?
- Included personal thoughts on the importance of domain modeling and communication between teams.
- Raised questions about the practical application of domain models and their maintenance.
- 2025/Domain-Driven Design Quickly/taehyoung/2.md
- Added notes and discussion points for Chapter 2: Ubiquitous Language.
- Discussed the importance of a common language between developers and domain experts.
- Shared personal experiences with communication errors and potential solutions.
- 2025/Domain-Driven Design Quickly/taehyoung/3.md
- Added notes and discussion points for Chapter 3: Model-Driven Design.
- Shared thoughts on layered architecture, service objects, and aggregates.
- Questioned the overuse of service objects and emphasized the importance of considering domain complexity when choosing an architecture.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the origin of the term 'ubiquitous'?
Click here for the answer
The word 'ubiquitous' comes from the Late Latin word 'ubiquitas', meaning 'everywhere'. It was first used in English in the 17th century.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request provides insightful reflections on the Domain-Driven Design Quickly book, focusing on key concepts like domain modeling, ubiquitous language, and model-driven design. The author shares personal experiences and poses thought-provoking questions for discussion. The content is well-structured and demonstrates a good understanding of the material.
Merge Readiness
The pull request is well-written and provides valuable insights into the concepts discussed in the book. There are no critical or high severity issues. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
PR 생성중 오류 발생해서 닫힘처리 후 다시 만들겠습니다 |
|
우측에 있는 |
책 내용과 관련해서 하고 싶은 말들이 많다보니, 책은 진작에 읽었는데, 정리가 좀 늦었네요 책은 재미있게 읽었습니다 Close #494