Fixing api #136
Fixing api #136
Conversation
Remaining TODO - Add duplicate schedule endpoint - Make API return next load time - Add authorization to the API through a middleware ;)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Stores for Saved (Course Pools for ReCal+) | ||
|
|
||
| import { getCurrentTerm } from "$lib/scripts/ReCal+/getters"; | ||
| import type { CourseData } from "$lib/types/dbTypes"; | ||
| import type { SupabaseClient } from "@supabase/supabase-js"; |
There was a problem hiding this comment.
The commit deletes src/lib/stores/rpool.ts, but many components still import $lib/stores/rpool (e.g. Calendar.svelte, ExportCal.svelte, AddSchedule.svelte, Top.svelte). Building the web app now fails with a missing-module error because the imported store no longer exists. Unless every caller is updated to a replacement, the store file needs to remain to keep the frontend compiling.
Useful? React with 👍 / 👎.
| import { | ||
| currentSchedule, | ||
| rawCourseData, |
There was a problem hiding this comment.
The removal of src/lib/scripts/ReCal+/fetchDb.ts leaves Top.svelte still importing from $lib/scripts/ReCal+/fetchDb, which will cause the web frontend to fail to compile with a "Cannot find module" error whenever the ReCal UI is built. Either restore the helper or change the remaining imports to a valid module.
Useful? React with 👍 / 👎.
The main chunk of the API is complete. I am now working on migrations to PostgreSQL and writing scripts for that.
WE STILL NEED TO DO AUTH THROUGH A MIDDLEWARE THOUGH!!