Svelte5 migration #142
Svelte5 migration #142
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <button | ||
| onclick={() => handleLogin(data.supabase)} | ||
| class="px-6 py-3 bg-black text-white text-xs tracking-[0.2em] uppercase | ||
| hover:bg-accent transition-colors"> |
There was a problem hiding this comment.
The landing page login CTA now uses plain onclick attributes instead of Svelte’s on:click directive (lines 52–55 and 72–75). Svelte treats onclick={...} as a literal DOM attribute, not an event listener, so the handleLogin handler is never invoked. As a result, clicking “Sign In” or “Get Started” no longer triggers authentication from the landing page. Switching back to on:click (or an equivalent event binding) is needed for these buttons to work.
Useful? React with 👍 / 👎.
No description provided.