Skip to content

chore: move quickstarts to declarative shadow variables #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

Christopher-Chianelli
Copy link
Contributor

Description of the change

Change usages of VariableListeners and CascadingShadowVariable to declarative shadow variables.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

One food-packaging ShadowVariable could not be migrated, since
it uses a non-declarative shadow on non-declarative shadow as a source.
@Christopher-Chianelli
Copy link
Contributor Author

Requires TimefoldAI/timefold-solver#1739

Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting a little bit ahead of ourselves here.

To put DSV in quickstarts, they first need to be promoted to public API.
To do that, there are still some outstanding issues.

No point in merging this before those happen, as this will all change anyway. (No preview, different imports, maybe even different names.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants