chore: create filtering value range selectors as early as possible

[zepfred]

This PR updates the value and entity factories to create the entity filtering-related selectors as early as possible. This way, the reachable values are returned first and then processed by outer node selectors. Additionally, it also includes a small change to minimize the hash lookup.

(The next PR will focus on these hash lookups)

[triceo]

Good start! Any performance numbers?

[triceo]

Getting closer.

Are we sure this doesn't change the moves that are generated? I mean - of course it does, that's the point, but are we sure no moves are lost that should not have been lost?

It is difficult to evaluate the logic of the move selector structure.

[zepfred]

Getting closer.

Are we sure this doesn't change the moves that are generated? I mean - of course it does, that's the point, but are we sure no moves are lost that should not have been lost?

It is difficult to evaluate the logic of the move selector structure.

Our FSR validation shows that invalid moves are no longer generated and the overall solution quality has improved, indicating that no valid moves are missed. Also, the coverage using the original iterators confirms that all expected moves are generated, and since the random iterators rely on the same approach, I don't think that's a problem.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud