Skip to content

Made GitHub cache update async and fixed cache refresh check. Fixes #… #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Made GitHub cache update async and fixed cache refresh check. Fixes #… #1316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11671ea
Made GitHub cache update async and fixed cache refresh check. Fixes #…
waliamehak Sep 3, 2025
2124e14
Merge branch 'Together-Java:develop' into develop
waliamehak Sep 4, 2025
20a27b5
Apply Spotless formatting
waliamehak Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions application/src/main/java/org/togetherjava/tjbot/features/github/GitHubCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
import net.dv8tion.jda.api.interactions.commands.OptionType;
import org.kohsuke.github.GHIssue;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.togetherjava.tjbot.features.CommandVisibility;
import org.togetherjava.tjbot.features.SlashCommandAdapter;
Expand All @@ -17,6 +19,7 @@
import java.util.List;
import java.util.PriorityQueue;
import java.util.Queue;
import java.util.concurrent.CompletableFuture;
import java.util.function.ToIntFunction;
import java.util.regex.Matcher;
import java.util.stream.Stream;
Expand All @@ -40,11 +43,12 @@ public final class GitHubCommand extends SlashCommandAdapter {
};

private static final String TITLE_OPTION = "title";
private static final Logger logger = LoggerFactory.getLogger(GitHubCommand.class);

private final GitHubReference reference;

private Instant lastCacheUpdate;
private List<String> autocompleteGHIssueCache;
private Instant lastCacheUpdate = Instant.EPOCH;
private List<String> autocompleteGHIssueCache = List.of();

/**
* Constructs an instance of GitHubCommand.
Expand All @@ -65,7 +69,14 @@ public GitHubCommand(GitHubReference reference) {
getData().addOption(OptionType.STRING, TITLE_OPTION,
"Title of the issue you're looking for", true, true);

updateCache();
CompletableFuture.runAsync(() -> {
try {
updateCache();
} catch (Exception e) {
logger.error("Unknown error updating the GitHub cache", e);
}
});

}

@Override
Expand Down Expand Up @@ -110,7 +121,7 @@ public void onAutoComplete(CommandAutoCompleteInteractionEvent event) {
event.replyChoiceStrings(choices).queue();
}

if (lastCacheUpdate.isAfter(Instant.now().minus(CACHE_EXPIRES_AFTER))) {
if (isCacheExpired()) {
updateCache();
}
}
Expand All @@ -120,12 +131,20 @@ private ToIntFunction<String> suggestionScorer(String title) {
return s -> StringDistances.editDistance(title, s.replaceFirst("\\[#\\d+] ", ""));
}

private boolean isCacheExpired() {
Instant cacheExpiresAt = lastCacheUpdate.plus(CACHE_EXPIRES_AFTER);
return Instant.now().isAfter(cacheExpiresAt);
}

private void updateCache() {
logger.debug("GitHub Autocomplete cache update started");

autocompleteGHIssueCache = reference.getRepositories().stream().map(repo -> {
try {
return repo.queryIssues().pageSize(1000).list().toList();
} catch (IOException ex) {
throw new UncheckedIOException(ex);
throw new UncheckedIOException("Error fetching issues from repo " + repo.getName(),
ex);
}
})
.flatMap(List::stream)
Expand All @@ -134,5 +153,8 @@ private void updateCache() {
.toList();

lastCacheUpdate = Instant.now();

logger.debug("GitHub autocomplete cache update completed successfully. Cached {} issues.",
autocompleteGHIssueCache.size());
}
}