perf: Make the code for adding group peers non-recursive. #2927
+51
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
nonrec-add_to_closest
branch
from
7119af9 to
e0eb205
Compare
Replaces the recursive implementation of add_to_closest in with an equivalent iterative loop. This eliminates the risk of stack overflow during deep peer eviction chains.
iphydf
force-pushed
the
nonrec-add_to_closest
branch
from
e0eb205 to
8e9a354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the recursive implementation of add_to_closest in with an equivalent iterative loop. This eliminates the risk of stack overflow during deep peer eviction chains.
This change is