Make options for Agent.prototype.getName optional
#378
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47817e0 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
In `@types/[email protected]`, `getName` was added with an optional argument, meaning `Agent` is not assignable to the `@types/node` declaration. This makes the `options` object optional and removes the unnecessary `options.secureEndpoint` check since `this.isSecureEndpoint` already handles it.
dgp1130
force-pushed
the
get-name-options
branch
from
eb511b3 to
47817e0
Compare
Closed
1 task
|
@TooTallNate this looks solid. Could you merge and release it? |
Owner
|
Thanks! |
|
@TooTallNate this helps, but some of my dependencies are pinning an old version of https-proxy-agent which is pinning |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
@types/[email protected],getNamewas added (DefinitelyTyped/DefinitelyTyped@239534a) with an optional argument, meaningAgentis not assignable to the@types/nodedeclaration. This makes theoptionsobject optional and removes the unnecessaryoptions.secureEndpointcheck sincethis.isSecureEndpointalready handles it.From history of
Agent.prototype.getNamein Node documentation:Based on that line, I think the
@types/nodeinterpretation is accurate and thisAgentimplementation should assume the parameter may not be provided.I do see several explicit
anyand@ts-expect-errorrelated to the fact thatgetNamewas not included in@types/node. Now that it is, it might be worth bumping this depending and resolving those typing issues, but that seems more involved so I decided to keep this PR narrowly scoped for now.I'm not 100% there aren't any more typing errors, but this is the only one I encountered when bumping
@types/node.