Eviction breaking side case fix for filesystem store #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
force-pushed
the
nested-evicition-break
branch
from
3e706f3 to
c4605cd
Compare
palfrey
commented
Nov 5, 2025
palfrey
commented
Nov 5, 2025
palfrey
changed the title
palfrey
force-pushed
the
nested-evicition-break
branch
2 times, most recently
from
432209e to
e0dbc60
Compare
palfrey
commented
Nov 6, 2025
| // file. To support this edge case, we first move the file to a temp file and point | ||
| // target file location to the new temp file. `unref()` should only ever be called once. | ||
| #[inline] | ||
| async fn unref(&self) { |
Member
Author
There was a problem hiding this comment.
A lot of this is whitespace changes as it had a double-nested {/} for some reason.
palfrey
force-pushed
the
nested-evicition-break
branch
from
e0dbc60 to
8249a8f
Compare
5 tasks
palfrey
force-pushed
the
nested-evicition-break
branch
from
8249a8f to
9537bdd
Compare
palfrey
force-pushed
the
nested-evicition-break
branch
from
9537bdd to
0f68eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a case where if you've got a filesystem store that's small enough, you can have a case where your entry gets evicted during insertion, and right now this causes a deadlock. To some extent, this is mostly a bad config (i.e. you should have a bigger store), but I suspect the same error can occur with much larger stores, depending on the exact eviction priorities on items. More specifically, we shouldn't be able to cause deadlock no matter how bad the config is, so this needs fixing either way.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...Checklist
bazel test //...passes locallygit amendsee some docsThis change is