-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Spells/Priest: Entropic Rift Implementation #31447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| } | ||
| }; | ||
|
|
||
| // 447444 - Entropic Rift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this spell lacks spell_proc entirely, also, according to sniff:
-
Mind Blast or Void Torrent are the original casts of 447445, so I would instead hook OnEffectHitTarget for both spells to trigger the AT effect (447445) if 447444 aura is present.
-
450193 effect, which creates the totem that allows to despawn the rift on the UI uses the AT effect (447445) as original cast. Also, I would force the AT to despawn when totem does.
-
459314 is nowhere to be seen in the sniff, but I'm pretty sure this one controls the tick rate on the AT, make sure to trigger it from 447445. This one should obtain the units inside from the AT to trigger the damaging spell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to do the 1st and 3rd points, but i still have issues on the 2nd one(still got to figure it out)
826e9c8 to
75194fa
Compare
Modified target lists from WorldObject to use Unit
1f3e764 to
bea52fe
Compare
05beba1 to
b4ef69b
Compare
Issues addressed:
Entropic Rift talent should make Mind Blast or Void Torrent to trigger a rift that follows the target and deals damage in its radius.
Also, if the target of the rift dies, it should move its focus on another target.
Even if the target dies when Mind Blast or Void Torrent gets casted, the Entropic Rift should spawn and stay still until you get in combat with an enemy, then the rift should start moving towards the target.
Closes # 826e9c8
Tests performed:
in-game, disc priest lvl 75 - Voidweaver