Added proper file locking to FileSaltStore
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmraible
changed the title
cmraible
force-pushed
the
fix-file-salt-store-multi-instance
branch
from
c917e3e to
185cf2b
Compare
cmraible
changed the title
FileSaltStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileSaltStoretests are flaky, particularly the 'should work correctly with multiple instances using same file' test. It turns out, the flakiness is from theFileSaltStore's implementation, not the test itself.When two instances of the service attempt to use the same file, they can experience a race condition when trying to initialize or write to the file. This fixes this by using a proper lockfile mechanism with the
proper-lockfilepackage.