Lily/MoreEvents: added "whenProjectPaused" and "whenProjectUnPause" #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
|
!format |
GarboMuffin
reviewed
Mar 31, 2025
| const topBlockId = script.blockId; | ||
| for (let j = 0; j < runtime.threads.length; j++) { | ||
| if ( | ||
| runtime.threads[j].topBlock === topBlockId && |
There was a problem hiding this comment.
This does not account for clones properly. The script is only going to run in one of the clones at a time since theyll have the same top block ID
There was a problem hiding this comment.
i am not quite sure how to fix this..
GarboMuffin
reviewed
Mar 31, 2025
GarboMuffin
reviewed
Mar 31, 2025
This comment was marked as abuse.
This comment was marked as abuse.
|
wait why is this closed, i didnt meant to close it lol |
|
I'm not a big fan of doing this as it is interfacing with a feature that is introduced through an addon and nothing internally. I'd rather it be introduced into a separate extension like Runtime Options, not here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.