Add oscillators extension #2187
Conversation
github-actions
bot
added
the
pr: new extension
|
!format |
|
The formatting bot couldn't push changes. Either maintainer edit permission is disabled or the pull request is from an organization/non-personal account. The author can run terminal command 'npm run format' manually to format all files. |
|
ok i moved this should work now |
|
!format |
|
The formatting bot couldn't push changes. Either maintainer edit permission is disabled or the pull request is from an organization/non-personal account. The author can run terminal command 'npm run format' manually to format all files. |
|
Is there something you would like me to do? |
|
I don't think that review will help you much because I'm not a moderator so I can't approve anything |
Co-authored-by: Brackets-Coder <[email protected]>
Co-authored-by: Brackets-Coder <[email protected]>
There was a problem hiding this comment.
Yep, all looks good. The one thing I'd say is don't use PenguinFork:master branch, you should have different branches for each Pull Request/Extension to help separate commits and organize things better 😉
Other than that, I'd say it's good enough. But you might want to collab with #1058, as it's a duplicate PR and you and @SharkPool-SP both want the same extension on the gallery. Either you both can make one extension or decide one or the other to merge
Added the oscillators extension