Change default Metadata value type to Any #1003
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Metadata
assumes that all the values it can hold areReal
s. This seems unnecessarily restrictive. For example, if I wake up one day and decide that I would like to use MCMC sampling to decide which fruit I should eat for breakfast:then I should really be able to do it. Unfortunately, right now, I can't, because
Metadata
expects its values to be stored inside aVector{<:Real}
, and aFruit
isn't aReal
.The main aim of this PR is to check what would happen on CI if we relaxed this bound to
Any
. After all,Real
is already abstract, so surely there isn't any type stability to be lost.With this PR, plus a bunch of overloads, we can actually evaluate these models:
I have not tested actual sampling with Turing.
Using #985 as the base just to reduce the number of different branching versions of the codebase I need to keep in mind.