Skip to content

Test on 1.12 #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test on 1.12 #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c7cb3
wrong way round
penelopeysm Nov 1, 2025
a93fb35
Test on 1.12
penelopeysm Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/Tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,20 @@ jobs:
- name: "everything else"
args: "--skip mcmc/gibbs.jl mcmc/Inference.jl ad.jl"
runner:
# TODO(mhauru) All the ones below that run on 1.11 should actually be run on 1.
# The current setup is a temporary arrangement to deal with issues where Mooncake
# and Libtask are broken on 1.12.
# Default
- version: '1.11'
- version: '1'
os: ubuntu-latest
num_threads: 1
# Multithreaded
- version: '1.11'
- version: '1'
os: ubuntu-latest
num_threads: 2
# Windows
- version: '1.11'
- version: '1'
os: windows-latest
num_threads: 1
# macOS
- version: '1.11'
- version: '1'
os: macos-latest
num_threads: 1
# Minimum supported Julia version
Expand Down
2 changes: 1 addition & 1 deletion test/ad.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ using ..Models: gdemo_default
import ForwardDiff, ReverseDiff

# Skip Mooncake on 1.12 as it is not compatible yet
const INCLUDE_MOONCAKE = VERSION >= v"1.12"
const INCLUDE_MOONCAKE = VERSION < v"1.12"
Copy link
Member Author

@penelopeysm penelopeysm Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly mistake I made previously.

if INCLUDE_MOONCAKE
import Pkg
Pkg.add("Mooncake")
Expand Down