refactor: editor monolith #1911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nperez0111
commented
Aug 4, 2025
nperez0111
commented
- refactor: split out managers from the editor instance
- refactor: split out collaboration & extensions to their own manager
- refactor: move location
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
commented
Aug 4, 2025
There was a problem hiding this comment.
This is not yet there, but will be the basis for the location api
matthewlipski
approved these changes
Aug 5, 2025
| @@ -303,9 +303,11 @@ export class BlockNoteTipTapEditor extends TiptapEditor { | |||
| if (!element) { | |||
| this.destroy(); | |||
| this.isInitialized = false; | |||
| this.emit("unmount", { editor: this }); | |||
There was a problem hiding this comment.
Is this smth relevant to splitting up the editor, or just a small fix that was added by the way?
matthewlipski
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.