Skip to content

feat: Add Integration Cards guidelines tool #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: Add Integration Cards guidelines tool #69

wants to merge 9 commits into from

Conversation

dimovpetar
Copy link
Member

@dimovpetar dimovpetar commented Oct 6, 2025 •
edited by flovogt
Loading

Adds a tool to offer guidelines for UI5 Integration cards.

JIRA: CPOUI5FOUNDATION-1147

@dimovpetar dimovpetar marked this pull request as draft October 6, 2025 08:35
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Oct 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@flovogt flovogt mentioned this pull request Oct 10, 2025
Open
@dimovpetar dimovpetar force-pushed the feat_cards_guidelines branch from ad85dfc to 50533b3 Compare October 14, 2025 10:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18493637194

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.58%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tools/get_integration_cards_guidelines/index.ts 1 5 20.0%
Totals Coverage Status
Change from base Build 18468470720: -0.1%
Covered Lines: 942
Relevant Lines: 1089
💛 - Coveralls

@dimovpetar dimovpetar marked this pull request as ready for review October 14, 2025 10:56
@flovogt flovogt requested a review from RandomByte October 14, 2025 12:23
@RandomByte RandomByte force-pushed the feat_cards_guidelines branch from 50533b3 to 74c0de5 Compare October 15, 2025 06:33
@RandomByte
Copy link
Member

Rebased to omit unrelated commits for review, renamed commit messages feat to refactor

akudev
akudev previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@akudev akudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RandomByte
RandomByte previously approved these changes Oct 15, 2025
View reviewed changes
@RandomByte
Copy link
Member

Waiting for final approval from @dimovpetar's team

alexandar-mitsev
alexandar-mitsev suggested changes Oct 15, 2025
View reviewed changes
Copy link

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new tool to Readme.md "Available Tools" section

@dimovpetar dimovpetar dismissed stale reviews from RandomByte and akudev via fe6cf30 October 17, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RandomByte RandomByte RandomByte left review comments

@akudev akudev akudev left review comments

@alexandar-mitsev alexandar-mitsev Awaiting requested review from alexandar-mitsev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dimovpetar @coveralls @RandomByte @alexandar-mitsev @akudev