feat(templates): Use manifest.json v2 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
force-pushed
the
template-use-manifest-v2
branch
from
f8b9d20 to
546410d
Compare
flovogt
force-pushed
the
template-use-manifest-v2
branch
from
546410d to
36eea51
Compare
akudev
requested changes
Oct 15, 2025
There was a problem hiding this comment.
The templates are supposed to work with UI5 versions down to 1.96
According to https://ui5.sap.com/sdk/docs/topics/be0cf40f61184b358b5faedaec98b2da.html this means 1.37.0 is the maximum we can set here, unless we set the version dynamically within the context of the template.
flovogt
force-pushed
the
template-use-manifest-v2
branch
2 times, most recently
from
1dc0a03 to
6ffcbee
Compare
flovogt
force-pushed
the
template-use-manifest-v2
branch
from
6ffcbee to
91d7083
Compare
akudev
previously approved these changes
Oct 15, 2025
|
The review assumes that the template content of manifest.json works with both manifest versions |
akudev
reviewed
Oct 15, 2025
akudev
dismissed
their stale review
Taking back the review until this is clarified
|
Schema 1.37.0 supports the routing config related properties. I am not aware of any properties not be present in 1.37.0 which we use in the template |
akudev
approved these changes
Oct 16, 2025
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With UI5 v1.136 the corresponding and recommended manifest version is
2.0.0. Therefore, also the template should use it.