-
Notifications
You must be signed in to change notification settings - Fork 16
feat: new eval schema changes #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radu-mocanu
wants to merge
14
commits into
main
Choose a base branch
from
release/revamped-evals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issues Address Copilot comments for coded evals
a3e9908
to
333821b
Compare
feat: wiring ExactMatch evaluator to new schema
feat: wiring JsonSimilarity evaluator to new schema
- Add version property detection to distinguish coded-evals from legacy files - Update pull command to map coded-evals folder to local evals structure - Update push command to upload files with version property to coded-evals folder - Maintain backward compatibility with legacy evals folder structure - Ensure eval command works out of the box with existing structure fix: resolve eval set path for correct evaluator discovery - Update load_eval_set to return both evaluation set and resolved path - Fix evaluator discovery by using resolved path instead of original path - Ensure eval command works with files in evals/eval-sets/ and evals/evaluators/ fix: cleaning up files fix: address PR review comments 1. Move eval_set path resolution from runtime to CLI layer - Resolve path in cli_eval.py before creating runtime - Remove context update in runtime since path is already resolved - Better separation of concerns 2. Clarify directory structure comments - Make it explicit that os.path.join produces {self.directory}/evals/evaluators/ - Prevent confusion about directory paths 3. Add file deletion consistency for evaluation files - Delete remote evaluation files when deleted locally - Matches behavior of source file handling - Ensures consistency across all file types Addresses: #681 (review) Addresses: #681 (review) Addresses: #681 (comment)
feat: adding pull and push for coded-evals folder files
feat: wiring LLM judge evaluators to new schema
…_evals feat: Cherry-pick progress on parallelization of eval runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
ToDo:
How to test:
example contains evaluator spec:
example eval set: