Skip to content

Fix issue where double decorator does not parse function name #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cvanelteren
Copy link
Contributor

@cvanelteren cvanelteren commented Aug 14, 2025

Context is in #319

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/tests/test_inputs.py 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren
Copy link
Contributor Author

Needs a test

@cvanelteren cvanelteren requested a review from beckermr August 14, 2025 16:38
@cvanelteren
Copy link
Contributor Author

Not sure why the test if failing on a non-related part.

@pgf
Copy link

pgf commented Aug 15, 2025

If this fix the issue, the _preprocess_or_redirect decorator should be redundant also in the other tri* methods, tricontour(f), right?

@cvanelteren
Copy link
Contributor Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants