Skip to content

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Oct 20, 2025

Scope and purpose

Resolves #3601. Depends on changes in #3599 and #3601.

This pull request

  • adds/changes/removes a dependency
  • changes the database
  • changes the API

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Oct 20, 2025
@Simrayz Simrayz added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Oct 20, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link

Test results

  3 files    3 suites   0s ⏱️
219 tests 219 ✅ 0 💤 0 ❌
222 runs  222 ✅ 0 💤 0 ❌

Results for commit e8dc226.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.20%. Comparing base (8b83fa9) to head (e8dc226).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3614       +/-   ##
===========================================
+ Coverage   62.51%   80.20%   +17.69%     
===========================================
  Files         611        6      -605     
  Lines       45020      197    -44823     
  Branches       43       43               
===========================================
- Hits        28142      158    -27984     
+ Misses      16868       29    -16839     
  Partials       10       10               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to request.user instead of request.account in templates (seddable)

2 participants