-
Notifications
You must be signed in to change notification settings - Fork 45
Add OS version and NAV version to exception debug view #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add OS version and NAV version to exception debug view #3645
Conversation
b315a06 to
5cb40c8
Compare
Test results 27 files 27 suites 45m 9s ⏱️ Results for commit 69ee8a3. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3645 +/- ##
==========================================
+ Coverage 62.67% 62.82% +0.14%
==========================================
Files 611 611
Lines 45100 45133 +33
Branches 43 43
==========================================
+ Hits 28266 28354 +88
+ Misses 16824 16769 -55
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
python/nav/django/settings.py
Outdated
| else: | ||
| OS_VERSION = f"{distro.name(pretty=True)} {distro.version()}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do on, say, FreeBSD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it should produce a decent output for other OSes like FreeBSD using the windows template, although it won't be as neat as for the big 3.
5cb40c8 to
69ee8a3
Compare
|



Scope and purpose
Fixes #2082.
Adds versions under "Settings" header
This pull request
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.