Skip to content

Conversation

@aleksfl
Copy link
Contributor

@aleksfl aleksfl commented Oct 31, 2025

Scope and purpose

Fixes #2082.

Adds versions under "Settings" header

This pull request

  • adds/changes/removes a dependency

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.

@aleksfl aleksfl self-assigned this Oct 31, 2025
@aleksfl aleksfl linked an issue Oct 31, 2025 that may be closed by this pull request
@aleksfl aleksfl force-pushed the feat/add-os-version-and-nav-version-to-exception-debug-view-email branch from b315a06 to 5cb40c8 Compare October 31, 2025 08:58
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Test results

    27 files      27 suites   45m 9s ⏱️
 2 665 tests  2 665 ✅ 0 💤 0 ❌
19 710 runs  19 710 ✅ 0 💤 0 ❌

Results for commit 69ee8a3.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.82%. Comparing base (1019a55) to head (69ee8a3).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
python/nav/django/settings.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3645      +/-   ##
==========================================
+ Coverage   62.67%   62.82%   +0.14%     
==========================================
  Files         611      611              
  Lines       45100    45133      +33     
  Branches       43       43              
==========================================
+ Hits        28266    28354      +88     
+ Misses      16824    16769      -55     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksfl aleksfl changed the title Add version info to settings Add OS version and NAV version to exception debug view Oct 31, 2025
@aleksfl aleksfl requested a review from a team October 31, 2025 10:45
Comment on lines 328 to 329
else:
OS_VERSION = f"{distro.name(pretty=True)} {distro.version()}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do on, say, FreeBSD?

Copy link
Contributor Author

@aleksfl aleksfl Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should produce a decent output for other OSes like FreeBSD using the windows template, although it won't be as neat as for the big 3.

@aleksfl aleksfl force-pushed the feat/add-os-version-and-nav-version-to-exception-debug-view-email branch from 5cb40c8 to 69ee8a3 Compare October 31, 2025 11:09
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OS version and NAV version to exception debug view/email

3 participants