CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) #2241

ekcoh · 2025-09-22T15:24:44Z

Description

This PR improves the "rebinding sample" in the following ways:

Adds a "swap bindings" button to showcase how to swap two similar bindings. This is currently applied to the move and look actions of the gamepad control scheme.
Improved RebindSaveLoad by documenting it and extracting Load/Save to API surface of the class and only calling them from OnEnable/OnDisable. Also made the actual PlayerPrefs key a string property of the component. This allows this file to be a reusable component as-is is nice there is nothing hard-coded and it may be used on OnEnable/OnDisable or just programatically.
Removed delta action binding from "Look" action since it is intentionally ignored by rebinding framework. This control is now instead replaced by a UI slider allowing to control/override mouse sensitivity of the associated action and persist the setting across runs.
Refactored rebinding sample custom editor code to reduce code bloat and enable code reuse via composition.
Extended "Reset All" button to also reset look sensitivity for "Keyboard & Mouse" scheme.
Added RebindActionParameterUI which is a slider UI integration example of configuring action processor parameters directly by adding the monobehavior, configuring it and run. Supports overriding action or binding processors.
Added RebindActionParameterUIEditor which is a custom editor for the above MonoBehaviour.

Testing status & QA

Functionality has been tested during development by running the associated sample.

Overall Product Risks

Small, no changes to source, only to sample scripts.

Complexity: Medium
Halo Effect: Small

Comments to reviewers

I am not 100% sure the scene save doesn't contain any accidental changes but I believe it should be fine.

Checklist

Before review:

Changelog entry added.
- Explains the change in Changed, Fixed, Added sections.
- For API change contains an example snippet and/or migration example.
- JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
- Jira port for the next release set as "Resolved".
Tests added/changed, if applicable.
- Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
- Performance tests.
- Integration tests.
Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.

During merge:

Commit message for squash-merge is prefixed with one of the list:
- NEW: ___.
- FIX: ___.
- DOCS: ___.
- CHANGE: ___.
- RELEASE: 1.1.0-preview.3.

After merge:

Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…ft and right sticks.

… in a row

…Parameter to enable mouse sensitivity setting.

…ameter override utility script.

…ameters to override.

…n portrait mode. Game manager now enforces landscape as part of running. Added menu button and reenabled UI actions during gameplay.

…shold is zero

…ogies/InputSystem into rebinding-sample-extension

codecov-github-com · 2025-10-06T14:38:54Z

Codecov Report

Attention: Patch coverage is 3.12500% with 248 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
Assets/Samples/RebindingUI/RebindActionEditor.cs	0.00%	84 Missing ⚠️
...ets/Samples/RebindingUI/RebindActionParameterUI.cs	0.00%	52 Missing ⚠️
...mples/RebindingUI/RebindActionParameterUIEditor.cs	0.00%	32 Missing ⚠️
Assets/Samples/RebindingUI/RebindSaveLoad.cs	0.00%	30 Missing ⚠️
Assets/Samples/RebindingUI/RequireTouchscreen.cs	0.00%	19 Missing ⚠️
Assets/Samples/RebindingUI/RebindActionUI.cs	15.78%	16 Missing ⚠️
Assets/Samples/RebindingUI/RebindActionUIEditor.cs	0.00%	6 Missing ⚠️
Assets/Samples/RebindingUI/ActionLabelEditor.cs	0.00%	3 Missing ⚠️
Assets/Samples/RebindingUI/InputActionIndicator.cs	0.00%	3 Missing ⚠️
Assets/Samples/RebindingUI/Game/GameplayManager.cs	0.00%	2 Missing ⚠️
... and 1 more

@@             Coverage Diff             @@
##           develop    #2241      +/-   ##
===========================================
- Coverage    76.70%   76.61%   -0.10%     
===========================================
  Files          465      470       +5     
  Lines        87919    88022     +103     
===========================================
- Hits         67442    67437       -5     
- Misses       20477    20585     +108

Flag	Coverage Δ
inputsystem_MacOS_2021.3	`5.91% <ø> (ø)`
inputsystem_MacOS_2021.3_project	`77.95% <3.12%> (-0.10%)`	⬇️
inputsystem_MacOS_2022.3	`5.37% <ø> (ø)`
inputsystem_MacOS_2022.3_project	`74.49% <3.12%> (-0.09%)`	⬇️
inputsystem_MacOS_6000.0	`5.19% <ø> (ø)`
inputsystem_MacOS_6000.0_project	`76.41% <3.12%> (-0.09%)`	⬇️
inputsystem_MacOS_6000.2	`5.19% <ø> (ø)`
inputsystem_MacOS_6000.2_project	`76.41% <3.12%> (-0.09%)`	⬇️
inputsystem_MacOS_6000.3	`5.19% <ø> (ø)`
inputsystem_MacOS_6000.3_project	`76.41% <3.12%> (-0.09%)`	⬇️
inputsystem_MacOS_6000.4	`5.19% <ø> (ø)`
inputsystem_MacOS_6000.4_project	`76.41% <3.12%> (-0.09%)`	⬇️
inputsystem_Ubuntu_2021.3	`5.91% <ø> (ø)`
inputsystem_Ubuntu_2021.3_project	`77.86% <3.12%> (-0.10%)`	⬇️
inputsystem_Ubuntu_2022.3	`5.38% <ø> (ø)`
inputsystem_Ubuntu_2022.3_project	`74.30% <3.12%> (-0.09%)`	⬇️
inputsystem_Ubuntu_6000.0	`5.19% <ø> (ø)`
inputsystem_Ubuntu_6000.0_project	`76.23% <3.12%> (-0.09%)`	⬇️
inputsystem_Ubuntu_6000.2	`5.19% <ø> (ø)`
inputsystem_Ubuntu_6000.2_project	`76.23% <3.12%> (-0.09%)`	⬇️
inputsystem_Ubuntu_6000.3	`5.19% <ø> (ø)`
inputsystem_Ubuntu_6000.3_project	`76.23% <3.12%> (-0.09%)`	⬇️
inputsystem_Ubuntu_6000.4	`5.19% <ø> (ø)`
inputsystem_Ubuntu_6000.4_project	`76.23% <3.12%> (-0.10%)`	⬇️
inputsystem_Windows_2021.3	`5.91% <ø> (ø)`
inputsystem_Windows_2021.3_project	`78.10% <3.12%> (-0.10%)`	⬇️
inputsystem_Windows_2022.3	`5.37% <ø> (ø)`
inputsystem_Windows_2022.3_project	`74.64% <3.12%> (-0.09%)`	⬇️
inputsystem_Windows_6000.0	`5.19% <ø> (ø)`
inputsystem_Windows_6000.0_project	`76.55% <3.12%> (-0.09%)`	⬇️
inputsystem_Windows_6000.2	`5.19% <ø> (ø)`
inputsystem_Windows_6000.2_project	`76.55% <3.12%> (-0.09%)`	⬇️
inputsystem_Windows_6000.3	`5.19% <ø> (ø)`
inputsystem_Windows_6000.3_project	`76.55% <3.12%> (-0.09%)`	⬇️
inputsystem_Windows_6000.4	`5.19% <ø> (ø)`
inputsystem_Windows_6000.4_project	`76.55% <3.12%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ssets/Samples/RebindingUI/InputActionExtensions.cs	`83.33% <83.33%> (ø)`
Assets/Samples/RebindingUI/Game/GameplayManager.cs	`0.00% <0.00%> (ø)`
Assets/Samples/RebindingUI/ActionLabelEditor.cs	`0.00% <0.00%> (ø)`
Assets/Samples/RebindingUI/InputActionIndicator.cs	`0.00% <0.00%> (ø)`
Assets/Samples/RebindingUI/RebindActionUIEditor.cs	`0.00% <0.00%> (ø)`
Assets/Samples/RebindingUI/RebindActionUI.cs	`55.93% <15.78%> (-3.72%)`	⬇️
Assets/Samples/RebindingUI/RequireTouchscreen.cs	`0.00% <0.00%> (ø)`
Assets/Samples/RebindingUI/RebindSaveLoad.cs	`0.00% <0.00%> (ø)`
...mples/RebindingUI/RebindActionParameterUIEditor.cs	`0.00% <0.00%> (ø)`
...ets/Samples/RebindingUI/RebindActionParameterUI.cs	`0.00% <0.00%> (ø)`
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ekcoh · 2025-10-07T06:09:10Z

Assets/Samples/RebindingUI/RebindActionEditor.cs

+    /// <summary>
+    /// Common binding UI helper to allow editor composition.
+    /// </summary>
+    internal class BindingUI


This isn't constantly named with file and should be renamed.

ritamerkl · 2025-10-07T10:31:50Z

I just tried the sample and I think the improvements are nice, I only have one point to critisize:
The swap button is very nondescript, I only discovered it after reading there is one.
I will look at the code now.

Pauliusd01 · 2025-10-08T08:15:21Z

I'm not sure if the sensitivity option is working, I can still rotate the character the same amount of times from the same amount of mouse distance regardless whether I'm on low or high sensitivity. (Maybe the differences between low and high are just very low? Since I didn't feel a difference at first what I did was go to the left edge of the screen and drag my mouse to the right counting full rotations of the character with both low and high sensitivity. Both totaling to around 2 full rotations exactly) Also, like Rita mentioned the swap button is tiny. Maybe spelling it out alongside the arrow icon would work. A crude example:

Otherwise looking good to me

ekcoh · 2025-10-09T09:56:47Z

I'm not sure if the sensitivity option is working, I can still rotate the character the same amount of times from the same amount of mouse distance regardless whether I'm on low or high sensitivity. (Maybe the differences between low and high are just very low? Since I didn't feel a difference at first what I did was go to the left edge of the screen and drag my mouse to the right counting full rotations of the character with both low and high sensitivity. Both totaling to around 2 full rotations exactly) Also, like Rita mentioned the swap button is tiny. Maybe spelling it out alongside the arrow icon would work. A crude example:
Otherwise looking good to me

I have a look if the slider is working, might be that I broke something while cleaning this up.

Regarding the swap button I can change it but vote to keep its current design but make it larger and to the right of the Reset buttons spanning the same height as the top of left stick button and bottom of right stick button.

…lt to click.

ekcoh · 2025-10-10T09:24:00Z

Made the swap button larger as requested.

ekcoh · 2025-10-10T09:25:46Z

I can confirm sensitivity slider is broken, will fix and rerequest review when done.

ekcoh added 10 commits September 22, 2025 17:22

Added "swap controls" button to rebinding sample to allow swapping le…

bb38389

…ft and right sticks.

Fixed a problem with previous swap bindings preventing multiple swaps…

a66c819

… in a row

Improved RebindSaveLoad to allow reuse, added embryo of RebindBinding…

ba19e19

…Parameter to enable mouse sensitivity setting.

Made load/save configurable on RebindSaveLoad component.

c0720c1

Refactoring of editor code, adding look sensitivity slider, added par…

76649d6

…ameter override utility script.

Simplified look sensitivity code

90f0b53

Generalized RebindActionParameterUI to make it possible to select par…

8178b94

…ameters to override.

Removed hardcoded parameter names

0962b73

Fixed a problem which would cause mobile rebind sample build to run i…

a579bfa

…n portrait mode. Game manager now enforces landscape as part of running. Added menu button and reenabled UI actions during gameplay.

Added rough on screen control that do not depend on UI

07161d9

ekcoh changed the title ~~Rebinding sample improvements~~ Rebinding sample improvements + on-screen controls Sep 26, 2025

ekcoh added 11 commits September 27, 2025 22:19

Additional work on on screen controls including UI visualisation

b854395

Minor changes to on screen controls.

1bc2c53

Fixed an issue where drag gesture wouldn't trigger directly when thre…

96b7c1e

…shold is zero

Code cleanup

d6ce1a0

Added inline doc

54ccf57

More work on onscreen controls.

59778c6

Removed files that will be routed via other PRs

df6a2b8

Removed undesirable object from scene

e0a8e1e

Removed meta file

ccfd328

Undo changes not related to rebind sample extension.

9276825

Merge branch 'develop' into rebinding-sample-extension

dd83145

ekcoh changed the title ~~Rebinding sample improvements + on-screen controls~~ ISX-2377: Rebinding sample improvements + on-screen controls (Validation week) Oct 6, 2025

ekcoh changed the title ~~ISX-2377: Rebinding sample improvements + on-screen controls (Validation week)~~ ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) Oct 6, 2025

ekcoh added 3 commits October 6, 2025 16:14

Updated changelog

0bd8359

Merge branch 'rebinding-sample-extension' of github.com:Unity-Technol…

d1e17bb

…ogies/InputSystem into rebinding-sample-extension

Slight improvements to README file

403e7d0

ekcoh marked this pull request as ready for review October 6, 2025 14:24

ekcoh requested review from ritamerkl and Pauliusd01 October 6, 2025 14:25

ekcoh changed the title ~~ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week)~~ CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) Oct 6, 2025

ekcoh commented Oct 7, 2025

View reviewed changes

Made swap button larger since it could be considered small or difficu…

483f743

…lt to click.

Fixed formatting issues in README.md

45536ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) #2241

CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) #2241

ekcoh commented Sep 22, 2025 •

edited

Loading

Uh oh!

codecov-github-com bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

ekcoh Oct 7, 2025

Uh oh!

ritamerkl commented Oct 7, 2025

Uh oh!

Pauliusd01 commented Oct 8, 2025 •

edited

Loading

Uh oh!

ekcoh commented Oct 9, 2025 •

edited

Loading

Uh oh!

ekcoh commented Oct 10, 2025

Uh oh!

ekcoh commented Oct 10, 2025

Uh oh!

Uh oh!

CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) #2241

Are you sure you want to change the base?

CHANGE: ISX-2377: Rebinding sample improvements (Mouse sensitivity + Swap sticks) (Validation week) #2241

Conversation

ekcoh commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing status & QA

Overall Product Risks

Comments to reviewers

Checklist

Uh oh!

codecov-github-com bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ekcoh Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

ritamerkl commented Oct 7, 2025

Uh oh!

Pauliusd01 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekcoh commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekcoh commented Oct 10, 2025

Uh oh!

ekcoh commented Oct 10, 2025

Uh oh!

Uh oh!

ekcoh commented Sep 22, 2025 •

edited

Loading

codecov-github-com bot commented Oct 6, 2025 •

edited

Loading

Pauliusd01 commented Oct 8, 2025 •

edited

Loading

ekcoh commented Oct 9, 2025 •

edited

Loading