CHANGE: Force reimport all assets into Unity 2022.3 LTS #2287
Conversation
K-Tone
changed the title
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2287 +/- ##
===========================================
+ Coverage 76.81% 77.95% +1.14%
===========================================
Files 476 477 +1
Lines 88726 97418 +8692
===========================================
+ Hits 68155 75947 +7792
- Misses 20571 21471 +900 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes 🚀 New features to boost your workflow:
|
When I open the project I get this file created |
|
Should we commit it? |
K-Tone
requested review from
josepmariapujol-unity
and removed request for
Pauliusd01
|
CC @Pauliusd01 for viz, no functional changes here, just asset reimport |
There was a problem hiding this comment.
Great to get this upgrade, I skimmed through the files and changes look good. I was surprised to not see a similar script to the PR description check in though, why don't we add this to e.g. /Assets/Tools/AssetUtilties.cs (The menu option only - see no value in the window), so you only need to go to e.g. "QA Tools/Force Reserialize All Assets" next time we do this? It can also be handy to use when e.g. messing with C# generators or asset generation/format changes that requires you to "manually" upgrade all of these.
|
What I suggested is essentially this: using UnityEditor;
using UnityEngine;
using System.IO;
static class AssetDatabaseMenuItems
{
// Use ForceReserializeAssets with the option to reserialize both assets and metadata
// This loads, upgrades, and writes all data back to disk.
[MenuItem("QA Tools/Force Reserialize All Assets")]
static void ForceReserializeAllAssets() =>
AssetDatabase.ForceReserializeAssets(AssetDatabase.GetAllAssetPaths(), ForceReserializeAssetsOptions.ReserializeAssetsAndMetadata);
}``` |
K-Tone
force-pushed
the
anthony/reimport-into-2022.3
branch
from
9936753 to
727c74f
Compare
josepmariapujol-unity
left a comment
josepmariapujol-unity
left a comment
There was a problem hiding this comment.
Tested manually, approved
Description
Here we force reimport all assets into Unity 2022.3 LTS with the means of this script:
This is done so that what we have on disk is actually 22.3 LTS data and not old data that is still usable due to compatibility paths. One of the benefits of this work is that with it landing, we won't get extra large diffs from doing seemingly small changes.
Testing status & QA
Local testing by dev.
Overall Product Risks
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.