fix: server exception loop #2652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NetworkManager.SceneManager.SynchronizeNetworkObjects got exception, there will always got exception in AddClient for add ConnectedClients dictionary multi times. Client and Server all get stuck.
|
|
|
Interesting... I think I see what you are talking about with that change. |
Duplicate GlobalObjectIdHash come out always, globalObjectId got null in some phase like PrefabImporterEditor::OnDestroy, another problem is GlobalObjectIdHash changed but prefab don't.
fix duplicate GlobalObjectIdHash & not save problem
michalChrobot
added
stat:awaiting-triage
EmandM
reviewed
Aug 19, 2025
| @@ -59,8 +59,20 @@ internal void GenerateGlobalObjectIdHash() | |||
| return; | |||
| } | |||
|
|
|||
| var globalObjectIdString = UnityEditor.GlobalObjectId.GetGlobalObjectIdSlow(this).ToString(); | |||
| var globalObjectId = UnityEditor.GlobalObjectId.GetGlobalObjectIdSlow(this); | |||
There was a problem hiding this comment.
Do you mind explaining what this change is doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NetworkManager.SceneManager.SynchronizeNetworkObjects got exception, there will always got exception in AddClient for add ConnectedClients dictionary multi times. Client and Server all get stuck.
Changelog
Testing and Documentation