Wait for used controllers in test setup #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise initial controller switches may fail
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 3.59% 16.63% +13.04%
==========================================
Files 13 33 +20
Lines 947 3432 +2485
Branches 152 429 +277
==========================================
+ Hits 34 571 +537
- Misses 843 2843 +2000
+ Partials 70 18 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
urmahp
approved these changes
Oct 6, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
* Wait for used controllers in test setup Otherwise initial controller switches may fail * Fix typo (cherry picked from commit bcbcac7) # Conflicts: # ur_robot_driver/test/integration_test_passthrough_controller.py # ur_robot_driver/test/integration_test_scaled_joint_controller.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
* Wait for used controllers in test setup Otherwise initial controller switches may fail * Fix typo (cherry picked from commit bcbcac7)
urfeex
pushed a commit
that referenced
this pull request
Oct 6, 2025
urfeex
added a commit
that referenced
this pull request
Oct 13, 2025
* Wait for used controllers in test setup Otherwise initial controller switches may fail * Fix typo (cherry picked from commit bcbcac7)
urfeex
pushed a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise initial controller switches may fail