Skip to content

[TF2] Fix Client Crashes from Invalid Banners Index's #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[TF2] Fix Client Crashes from Invalid Banners Index's #1526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1f5f2
Fix Client Crashes from Invalid Banners
ChaseTownsend Sep 11, 2025
0cd0bac
Move prevention above creating the Banner
ChaseTownsend Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/game/shared/tf/tf_weapon_buff_item.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,16 +306,24 @@ void CTFBuffItem::CreateBanner()
if ( !pPlayer || !pPlayer->IsAlive() )
return;

int iBuffType = GetBuffType();
// Prevent Crashes From Invalid Buff Types
if ( iBuffType > ARRAYSIZE(BannerModels) || iBuffType <= 0 )
{
DevMsg("Invalid buff type %d, Not Creating Banner\n", iBuffType);
return;
}

C_TFBuffBanner* pBanner = new C_TFBuffBanner;
if ( !pBanner )
return;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace

Suggested change

//Assert( iBuffType > 0 );
//Assert( iBuffType <= ARRAYSIZE(BannerModels) );
pBanner->m_nSkin = 0;
pBanner->InitializeAsClientEntity( BannerModels[GetBuffType()-1], RENDER_GROUP_OPAQUE_ENTITY );
pBanner->InitializeAsClientEntity( BannerModels[iBuffType-1], RENDER_GROUP_OPAQUE_ENTITY );
pBanner->SetBuffItem( this );
pBanner->SetBuffType( GetBuffType() );
pBanner->SetBuffType( iBuffType );
pBanner->ForceClientSideAnimationOn();
SetBanner( pBanner );
int iSpine = pPlayer->LookupBone( "bip_spine_3" );
Expand Down