[TF2] fix: cleanup collect on rest logic #1534
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the provided utility functions for trigger_hurt and respawn room to determine the validity of the trigger, rather than doing a broader, incorrect bounds check.
|
#1307 duplicate |
That PR differs with this one, this PR uses the shared utility functions and does not do other changes. |
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the provided utility functions for trigger_hurt and respawn room to determine the relevance of the trigger, rather than doing a broader, incorrect bounds check. This takes into consideration all the relevant conditions for each respective trigger to be valid, and checks if the currency's point is truly within the trigger.
This fixes an error where some maps with more complex geometry for their triggers will cause a currency pickup in random locations, which was exacerbated by #618, which added respawn rooms to the logic.