Skip to content

feat!: adjust default compilerOptions to TypeScript 5.9+'s default #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat!: adjust default compilerOptions to TypeScript 5.9+'s default #525

wants to merge 8 commits into from
+33 −6

Conversation

@sushichan044
Copy link
Member

@sushichan044 sushichan044 commented Jul 27, 2025 •
edited
Loading

https://devblogs.microsoft.com/typescript/announcing-typescript-5-9-rc/
TypeScript 5.9 から tsc --init した際の設定値が変更されます。

この設定を見たところ、エコシステムの問題で有効化を見送っていた compilerOptions がいくつかデフォルトで有効になっていました。
今後有効化していて当たり前のオプションとなることが予想されるため、preset にも適用します。

具体的な変更

  • exactOptionalPropertyTypes の有効化
  • verbatimModuleSyntax の有効化
  • noUncheckedSideEffectImports の有効化
    • peerDeps で TS 5.6 以上を要求しています

@sushichan044 sushichan044 self-assigned this Jul 27, 2025
@github-actions github-actions bot added the tsconfig Issues about tsconfig label Jul 27, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 27, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@virtual-live-lab/tsconfig@525

commit: f47b614

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f47b614

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@virtual-live-lab/tsconfig Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sushichan044
Copy link
Member Author

sushichan044 commented Jul 27, 2025

@mimifuwa @sevenc-nanashi
module, target, lib, moduleDetection, types あたりはどうするか判断できずだったので意見いただけると嬉しいです！

@sushichan044 sushichan044 marked this pull request as ready for review July 27, 2025 15:16
@sushichan044
Copy link
Member Author

sushichan044 commented Jul 27, 2025

📝 mikuec com で CI を回してみる

@sushichan044
Copy link
Member Author

sushichan044 commented Jul 27, 2025 •
edited
Loading

astro-seo まわりで爆発してそうだが、これは自分たちが良くないので直せば良さそう

sevenc-nanashi
sevenc-nanashi approved these changes Jul 27, 2025
View reviewed changes
Copy link

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

設定自体には特に問題なさそう。

@sushichan044
Copy link
Member Author

sushichan044 commented Oct 30, 2025

exactOptionalPropertyTypes やっぱり各所で困るという肌感があるのでダメな気がしてきた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@mimifuwacc mimifuwacc Awaiting requested review from mimifuwacc

Assignees

@sushichan044 sushichan044

Labels

tsconfig Issues about tsconfig

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sushichan044 @sevenc-nanashi