Simplify createConnection usage and pendingConnectionList handling #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn as well - remove locking and atomics around pendingConnectionList to reduce cpu serialization and simplify code - initiateConnection should not create defered connections as it might create duplicates in pendingConnectionList
- restore ClientTest.cpp indentation
|
forgot to mention about initiateConenction(), it could create duplicate pending connections in the list, so I removed calls to create deferred connection calls on errors. this should be handled by initiateConenction() callers |
- fix autoReconnect only for enabled connections on connection lost event - fix unitests, cleanup listener pointer at the end of everu testunit, as it points to a local variable - few cleanups
|
I found and fixed few other problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main idea is to simplify pendingConnectionList handling by accessing it only with in libevent handlers, this allowed lock and atomic removal around it.
As well I changed createConnection so it handles both usecases, synchronous and deferred connects.