Allow calls to descriptor_table_update() to initialize descriptor table #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking reads/writes to stdin/stdout/stderr.
Also check return values from init_{stdin, stdout, stderr}, although
this may not help much since the return values from printf()/etc.
aren't usually checked.
|
Note: I tested this manually, since with the current test suite, writing anything to stdout/stderr is considered a test failure. This should probably be improved, but I'm technically on vacation so I'll wait on that. |
|
Fixes #625 |
| } | ||
|
|
||
| // Translate the file descriptor to an internal handle | ||
| descriptor_table_get_ref(fildes, &entry); |
There was a problem hiding this comment.
(feel free to defer this to when you get back from vacation, this isn't urgent)
should the return value here also be checked to return EBADF if this call fails?
There was a problem hiding this comment.
Good point. Fixed in e1ff08d -- I also found/fixed a number of other places where the return value of descriptor_table_get_ref() and similar methods wasn't checked.
pchickey
approved these changes
Oct 8, 2025
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking reads/writes to stdin/stdout/stderr.
Also check return values from init_{stdin, stdout, stderr}, although this may not help much since the return values from printf()/etc. aren't usually checked.