Skip to content

Conversation

camillobruni
Copy link
Contributor

Runs a in-memory typescript compilation of the immer library.

  • npm run build downloads and build src/gen in-memory file contents for 3 different libs (for local testing)
  • webpack is used to bundle the results
  • There are some type warnings, but all files seem to be loaded

Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit f07f378
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68add5924bd99c000851b1e4
😎 Deploy Preview https://deploy-preview-117--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good workload, although sadly on it's last legs... I guess it will become a wasm benchmark when the Go transition happens 🙂

Can we add a README.md with the steps to rebuild?

@camillobruni
Copy link
Contributor Author

Added README and license.

@kmiller68
Copy link
Contributor

Looks like this test also has a bunch of comments that have non-latin1 characters in them. We should probably fix that.

That said, I'm a bit conflicted. It seems like this benchmark combines .ts source files into the final script, which seems odd. I would've expected that the .ts files we're going to parse/compile would come from side files that are loaded into JS strings and subsequently get passed to the typescript compiler. If those source files were non-latin1, I'd be fine with that but since they're mixed with the typescript compiler itself (IIUC, anyway) that seems harder.

@camillobruni
Copy link
Contributor Author

Fair point, let me change that to something where we load the resources (.ts sources) separately and feed them as JS strings to TypeScriptCompileTest.compileTest();. That's also more in line with how other workloads currently handle resources, and it makes it easier to swap out the source projects for local testing.

@camillobruni
Copy link
Contributor Author

  • Updated the benchmark to load the config fils (tsconfig.json and files.json) separate and feed them to the TS compiler
  • Updated webpack to use the UnicodeEscapePlugin just to be sure (will double check again after landing the 2-byte test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants