Add complexity param #430
Open
Add complexity param #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillobruni
commented
Oct 9, 2024
|
Without looking closely at the code change, I think this is a neat idea and I could imagine us increasing the complexity of charts, text editing, etc if we move forward with it. Will be curious for feedback from @julienw. |
|
This was referenced Nov 7, 2024
…10-09_complexity_param
|
I've now changed the complexity slider to have an exponential scale which makes it a bit more comfortable to use. |
…10-09_complexity_param
rniwa
reviewed
Jan 7, 2025
rniwa
reviewed
Jan 7, 2025
…10-09_complexity_param
…10-09_complexity_param
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
julienw
reviewed
May 21, 2025
|
We should probably log all non-standard params to the json file. |
julienw
approved these changes
May 28, 2025
…10-09_complexity_param
…10-09_complexity_param
|
This is ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on params.mjs changes in #469
Work in progress proposal for adding a variable complexity param.
complexity === 1.0: workloads run in default configurationcomplexity > 1.0: ideally workloads run proportionally slowercomplexity < 1.0: ideally workloads run proportionally fastBackground:
We're occasionally seeing issues with gc timing / optimisations heuristics with the current workloads. If we can dynamically change the duration / complexity of workloads it's a bit easier to assess how good these heuristics are and how much we're potentially overfitting.
Current Limitations: