[WTF][WPE] Read the log level string from an Android system property #47352

aperezdc · 2025-06-29T12:37:42Z

`f8b520c`

[WTF][WPE] Read the log level string from an Android system property
https://bugs.webkit.org/show_bug.cgi?id=295175

Reviewed by Nikolas Zimmermann and Michael Catanzaro.

Read the value of the debug.WPEWebKit.log system property to determine
the value returned by WTF::logLevelString() to configure logging
channels on Android.

This allows using the "setprop" command line tool to configure logging:

  adb shell setprop debug.WPEWebKit.log 'Scrolling,Loading'

* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/android/LoggingAndroid.cpp: Copied from Source/WTF/wtf/unix/LoggingUnix.cpp.
(WTF::logLevelString):
* Source/WTF/wtf/unix/LoggingUnix.cpp: Guard with !OS(ANDROID); remove
unneeded <string.h> header inclusion, and make logLevel "const" as
drive-by fixes.
(WTF::logLevelString):

Canonical link: https://commits.webkit.org/297467@main

44383f0

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-29T12:37:47Z

EWS run on previous version of this PR (hash f292bc1)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

aperezdc · 2025-06-29T12:39:08Z

This is most useful in combination with #47339 in order to have the logging messages sent to the Android logging service.

Source/WTF/wtf/unix/LoggingUnix.cpp

spenap

Philippe has a valid question, but I'm OK with both your approach and his suggestion. The changes look good!

webkit-early-warning-system · 2025-06-30T11:25:59Z

EWS run on previous version of this PR (hash e22246b)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-30T11:29:43Z

EWS run on previous version of this PR (hash 6adbad7)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-07-01T15:11:33Z

EWS run on previous version of this PR (hash 6e676d2)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

aperezdc · 2025-07-07T20:39:58Z

Ping reviewers 🏓

mcatanzaro

I would do this in a separate LoggingAndroid.cpp, because now half of LoggingUnix.cpp is unrelated to Unix. But whatever.

Source/WTF/wtf/unix/LoggingUnix.cpp

aperezdc · 2025-07-09T16:00:36Z

I would do this in a separate LoggingAndroid.cpp, because now half of LoggingUnix.cpp is unrelated to Unix. But whatever.

Actually, I am going to do that. It makes little sense in Android anyway to use environment variables (it's quite inconvenient, requires rebuilding the application package with a wrapper script) and I will make it only read the system property at runtime.

webkit-early-warning-system · 2025-07-09T22:56:58Z

EWS run on previous version of this PR (hash 55e3a44)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WTF/wtf/android/LoggingAndroid.cpp

svillar

Shouldn't we include the adb command in docs? It's quite useful for developing and it'd be a shame forcing devs to look in the code if they can just see it on a README

aperezdc · 2025-07-16T11:30:09Z

Shouldn't we include the adb command in docs? It's quite useful for developing and it'd be a shame forcing devs to look in the code if they can just see it on a README

My plan was to send a PR to update the page at https://docs.webkit.org/Build%20%26%20Debug/Logging.html but indeed it would be good to have it in the manual. I can do that in a follow-up patch, too.

webkit-early-warning-system · 2025-07-16T13:32:28Z

EWS run on current version of this PR (hash 44383f0)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Document that the WPE port logs to the logd service on Android, and is configured using system properties, after the two following patches: - WebKit/WebKit#47339 - WebKit/WebKit#47352

aperezdc · 2025-07-16T13:57:30Z

Shouldn't we include the adb command in docs? It's quite useful for developing and it'd be a shame forcing devs to look in the code if they can just see it on a README

My plan was to send a PR to update the page at https://docs.webkit.org/Build%20%26%20Debug/Logging.html but indeed it would be good to have it in the manual. I can do that in a follow-up patch, too.

Done here for the documentation site: WebKit/Documentation#128

https://bugs.webkit.org/show_bug.cgi?id=295175 Reviewed by Nikolas Zimmermann and Michael Catanzaro. Read the value of the debug.WPEWebKit.log system property to determine the value returned by WTF::logLevelString() to configure logging channels on Android. This allows using the "setprop" command line tool to configure logging: adb shell setprop debug.WPEWebKit.log 'Scrolling,Loading' * Source/WTF/wtf/PlatformWPE.cmake: * Source/WTF/wtf/android/LoggingAndroid.cpp: Copied from Source/WTF/wtf/unix/LoggingUnix.cpp. (WTF::logLevelString): * Source/WTF/wtf/unix/LoggingUnix.cpp: Guard with !OS(ANDROID); remove unneeded <string.h> header inclusion, and make logLevel "const" as drive-by fixes. (WTF::logLevelString): Canonical link: https://commits.webkit.org/297467@main

webkit-commit-queue · 2025-07-16T14:18:35Z

Committed 297467@main (f8b520c): https://commits.webkit.org/297467@main

Reviewed commits have been landed. Closing PR #47352 and removing active labels.

aperezdc · 2025-07-16T22:17:12Z

Backported into webkitglib/2.48 as commit 9281920

Document that the WPE port logs to the logd service on Android, and is configured using system properties, after the two following patches: - WebKit/WebKit#47339 - WebKit/WebKit#47352

aperezdc requested a review from a team as a code owner June 29, 2025 12:37

aperezdc self-assigned this Jun 29, 2025

aperezdc added the WPE WebKit WebKit WPE component label Jun 29, 2025

aperezdc requested a review from spenap June 29, 2025 12:38

aperezdc mentioned this pull request Jun 29, 2025

[WPE] Log messages to the Android log where appropriate #47339

Merged

philn reviewed Jun 29, 2025

View reviewed changes

Source/WTF/wtf/unix/LoggingUnix.cpp Outdated Show resolved Hide resolved

spenap reviewed Jun 30, 2025

View reviewed changes

aperezdc force-pushed the android-logging-sysprop branch from f292bc1 to e22246b Compare June 30, 2025 11:25

aperezdc force-pushed the android-logging-sysprop branch from e22246b to 6adbad7 Compare June 30, 2025 11:29

aperezdc requested review from philn and spenap June 30, 2025 11:30

aperezdc changed the title ~~[WTF][WPE] Read the log level string from an Android system property~~ [WPE] Log messages to the Android log where appropriate Jul 1, 2025

aperezdc changed the title ~~[WPE] Log messages to the Android log where appropriate~~ [WTF][WPE] Read the log level string from an Android system property Jul 1, 2025

aperezdc force-pushed the android-logging-sysprop branch from 6adbad7 to 6e676d2 Compare July 1, 2025 15:11

aperezdc added the GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch label Jul 1, 2025

mcatanzaro approved these changes Jul 7, 2025

View reviewed changes

Source/WTF/wtf/unix/LoggingUnix.cpp Show resolved Hide resolved

aperezdc force-pushed the android-logging-sysprop branch from 6e676d2 to 55e3a44 Compare July 9, 2025 22:56

aperezdc requested review from mcatanzaro and a team July 10, 2025 21:09

nikolaszimmermann approved these changes Jul 16, 2025

View reviewed changes

Source/WTF/wtf/android/LoggingAndroid.cpp Outdated Show resolved Hide resolved

Source/WTF/wtf/android/LoggingAndroid.cpp Outdated Show resolved Hide resolved

svillar reviewed Jul 16, 2025

View reviewed changes

aperezdc force-pushed the android-logging-sysprop branch from 55e3a44 to 44383f0 Compare July 16, 2025 13:32

aperezdc added the merge-queue Applied to send a pull request to merge-queue label Jul 16, 2025

aperezdc removed the merge-queue Applied to send a pull request to merge-queue label Jul 16, 2025

aperezdc changed the title ~~[WTF][WPE] Read the log level string from an Android system property~~ [WPE] Log messages to the Android log where appropriate Jul 16, 2025

aperezdc added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Jul 16, 2025

aperezdc changed the title ~~[WPE] Log messages to the Android log where appropriate~~ [WTF][WPE] Read the log level string from an Android system property Jul 16, 2025

aperezdc added the merge-queue Applied to send a pull request to merge-queue label Jul 16, 2025

webkit-commit-queue force-pushed the android-logging-sysprop branch from 44383f0 to f8b520c Compare July 16, 2025 14:18

webkit-commit-queue merged commit f8b520c into WebKit:main Jul 16, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 16, 2025

aperezdc deleted the android-logging-sysprop branch July 16, 2025 16:31

aperezdc removed the GLib Suggested Backport - 2.48 Suggest this merge request be backported to webkitglib/2.48 branch label Jul 16, 2025

[WTF][WPE] Read the log level string from an Android system property #47352

[WTF][WPE] Read the log level string from an Android system property #47352

Conversation

aperezdc commented Jun 29, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

f8b520c

Uh oh!

webkit-early-warning-system commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aperezdc commented Jun 29, 2025

Uh oh!

Uh oh!

spenap left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aperezdc commented Jul 7, 2025

Uh oh!

mcatanzaro left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aperezdc commented Jul 9, 2025

Uh oh!

webkit-early-warning-system commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svillar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aperezdc commented Jul 16, 2025

Uh oh!

webkit-early-warning-system commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aperezdc commented Jul 16, 2025

Uh oh!

webkit-commit-queue commented Jul 16, 2025

Uh oh!

aperezdc commented Jul 16, 2025

Uh oh!

Uh oh!

aperezdc commented Jun 29, 2025 •

edited by webkit-early-warning-system

Loading

`f8b520c`

webkit-early-warning-system commented Jun 29, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2025 •

edited

Loading

webkit-early-warning-system commented Jul 1, 2025 •

edited

Loading

mcatanzaro left a comment •

edited

Loading

webkit-early-warning-system commented Jul 9, 2025 •

edited

Loading

svillar left a comment •

edited

Loading

webkit-early-warning-system commented Jul 16, 2025 •

edited

Loading